Conversation
122824b to
9f03380
Compare
rmulhol
suggested changes
Sep 15, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Need to decode the data payload as an address instead of a big int
environments/docker.toml
Outdated
| type = "eth_event" | ||
| repository = "github.com/makerdao/vdb-mcd-transformers" | ||
| migrations = "db/migrations" | ||
| contracts = ["MCD_FLIP_BAT_A_1.1.0", "MCD_FLIP_ETH_A_1.1.0", "MCD_FLIP_KNC_A_1.1.0", "MCD_FLIP_MANA_A_1.1.0", |
Contributor
There was a problem hiding this comment.
Popping in to note that this might need to be updated if merged after #299
9f03380 to
7656e37
Compare
7656e37 to
394b864
Compare
rmulhol
approved these changes
Sep 16, 2020
rmulhol
reviewed
Sep 16, 2020
394b864 to
ab00a2e
Compare
ab00a2e to
faa68eb
Compare
rmulhol
reviewed
Sep 16, 2020
| "MCD_FLIP_USDC_A_1.1.0", | ||
| "MCD_FLIP_USDC_B_1.1.0", | ||
| "MCD_FLIP_WBTC_A_1.1.0", | ||
| "MCD_FLIP_ZRX_A_1.1.0", |
Contributor
There was a problem hiding this comment.
I think we can probably shore this up after the backfill process is running, but in theory this should include the PAXUSD + USDT addresses
Contributor
Author
There was a problem hiding this comment.
ugg.. forgot about this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new transformer for the
flipcontract to trackfile_catevents.