(VDB-1594) Add 1.1.0 addresses [staging]#300
Merged
Conversation
9d05442 to
c0a4b71
Compare
yaoandrew
approved these changes
Sep 21, 2020
Contributor
yaoandrew
left a comment
There was a problem hiding this comment.
Just had a question on the newer collateral additions. Otherwise LGTM. 🚀
| "MCD_FLIP_ETH_A_1.1.0", | ||
| "MCD_FLIP_KNC_A_1.1.0", | ||
| "MCD_FLIP_MANA_A_1.1.0", | ||
| "MCD_FLIP_TUSD_A_1.1.0", |
Contributor
There was a problem hiding this comment.
Do we need USDT and PAXUSD added here or is that in another PR?
| @@ -336,11 +336,13 @@ | |||
| repository = "github.com/makerdao/vdb-mcd-transformers" | |||
Contributor
There was a problem hiding this comment.
Do we also need to add these new contract versions to the storage transformers list as well?
Contributor
There was a problem hiding this comment.
Also, I think we'd need new storage transformer initializers for those as well.
Contributor
Author
cf87c4b to
99f32b1
Compare
added 16 commits
September 22, 2020 14:27
- So that they're tracked in diffing service
- include cat field
a6e65d0 to
8d515ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.