(VDB-1606) Add Flip v1.1.0 storage transformers#298
Merged
Conversation
Contributor
rmulhol
commented
Sep 9, 2020
- include cat field
e755c2c to
cbefe46
Compare
elizabethengelman
approved these changes
Sep 15, 2020
Contributor
elizabethengelman
left a comment
There was a problem hiding this comment.
Looks good - just that one comment about the flip_tusd transformer name in docker.toml.
environments/docker.toml
Outdated
| "flip_sai_v1_0_0", | ||
| "flip_tusd_a_v1_0_7", | ||
| "flip_tusd_a_v1_0_9", | ||
| "flip_tusd_a_V1_1_0", |
Contributor
There was a problem hiding this comment.
super small, but I think we want this V1 to be v1 so that it matches with the exporter?
- include cat field
cbefe46 to
ddfcad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.