Update cat file transformer with chop lump dunk [beta edition]#297
Merged
Update cat file transformer with chop lump dunk [beta edition]#297
Conversation
rmulhol
suggested changes
Sep 9, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Needs to be addressed via backwards-compatible changes (new migration and/or leaving the table name unchanged [leaving the table unchanged actually isn't that bad of an option since we can always alias in postgraphile])
rmulhol
reviewed
Sep 9, 2020
transformers/component_tests/queries/all_ilk_file_events_query_test.go
Outdated
Show resolved
Hide resolved
1734411 to
85d2672
Compare
elizabethengelman
approved these changes
Sep 15, 2020
rmulhol
reviewed
Sep 15, 2020
rmulhol
approved these changes
Sep 15, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Would prefer to remove the CatFileChopDunkSignature() method + private functions it calls (and get rid of the test) since I think we can use/rename CatFileChopLumpSignature() - otherwise LGTM 👍
85d2672 to
fc0330f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new PR which modifies the existing cat file chop lump transformer to save
cat1.1.0dunk events.