Conversation
151ab24 to
645cc81
Compare
| DartColumn event.ColumnName = "dart" | ||
| DataColumn event.ColumnName = "data" | ||
| DinkColumn event.ColumnName = "dink" | ||
| DustColumn event.ColumnName = "dust" |
There was a problem hiding this comment.
Is this only used in the Oasis transformers? I'm just thinking there's a vat_file what = "dust", but maybe there aren't any event.ColumnName entries for dust?
There was a problem hiding this comment.
I believe this file should only need to contain columns that are used in the oasis transformers (and their schema). I would have thought that we could also get rid of dink/dart and some of the other column names in this file
There was a problem hiding this comment.
Whoops I totally misunderstood this - we need dink/dart because this is MCD not Oasis 🤦
I'm assuming the dust column wasn't actually used anywhere (as you suggested, since it's just a what value that gets parsed as a string)
ba28ea6 to
181192a
Compare
|
Might need to coordinate this with tech ops but I wonder if we want to make sure any names like |
26480fa to
4576d0b
Compare
|
Mentioned this in the Oasis PR but let's get the docker images renamed as part of the deployment stories. |
- remove Oasis tables from schema - remove Oasis transformer code + config - remove Oasis test data + integration tests
So that execute will now check it, instead of the public.headers table.
This version has the CheckedHeadersRepository that respects a schema name. It meant updating the integration tests, which is a good thing, as it shows the repository works.
It's an integration test because it "integrates" with vulcanizedb and there's no repository on the plugin side.
Use the provided helper method from vulcanizedb, and update to the "latest" one in the branch so that it is present.
4576d0b to
1725046
Compare
WIP until we're confident about running Oasis stuff from a separate repo