(VDB-1594) Additional Bite/Flip integration tests#292
Merged
Conversation
855f5a1 to
6a23f92
Compare
5d78b2b to
11d8b85
Compare
Contributor
Author
|
This is the first incremental chunk in what will likely be an ongoing effort to get caught up on integration tests. Marking it for review now because (1) there are some higher priority things that need attention right now, and (2) don't want to bloat the diff too much |
yaoandrew
approved these changes
Sep 9, 2020
| Flip: test_data.FlipEthV100Address(), | ||
| Id: "112", | ||
| } | ||
| biteIntegrationTest(blockNumber, test_data.Cat100Address(), constants.Cat100ABI(), ilk, urn, expectedResult) |
| // TODO: add MCD_FLIP_ZRX_A_1.1.0 test when available | ||
| }) | ||
|
|
||
| func flipKickIntegrationTest(blockNumber int64, contractAddressHex, contractABI string, expectedResult flipKickModel) { |
Contributor
There was a problem hiding this comment.
🥇 Nice.. I like the way this looks.
11d8b85 to
129d8bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.