Merged
Conversation
33bf661 to
bde2c99
Compare
rmulhol
reviewed
Nov 27, 2019
| @@ -502,7 +502,6 @@ CREATE FUNCTION api.all_bites(ilk_identifier text, max_results integer DEFAULT ' | |||
| LANGUAGE sql STABLE STRICT | |||
Contributor
There was a problem hiding this comment.
Mind popping this off of this PR? I think for some reason our schema formatters are not in agreement about whether these spaces should be here, so we'll probably be going back and forth regularly. But at least maybe we can limit that to cases where we're also making a substantive change to the schema
gslaughl
approved these changes
Nov 27, 2019
| db = test_config.NewTestDB(test_config.NewTestNode()) | ||
| test_config.CleanTestDB(db) | ||
| headerRepo = repositories.NewHeaderRepository(db) | ||
| flapKickRepo = flap_kick.Repository{} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✂️ 🎉