VDB-1598: cat claw staging [staging]#288
Merged
elizabethengelman merged 6 commits intostagingfrom Sep 9, 2020
Merged
Conversation
6519e4c to
e29bf00
Compare
paytonrules
reviewed
Sep 3, 2020
| address_id BIGINT NOT NULL REFERENCES public.addresses (id) ON DELETE CASCADE, | ||
| log_id BIGINT NOT NULL REFERENCES public.event_logs (id) ON DELETE CASCADE, | ||
| msg_sender BIGINT NOT NULL REFERENCES addresses (id) ON DELETE CASCADE, | ||
| rad NUMERIC, |
Contributor
There was a problem hiding this comment.
Why is this rad and not litter?
Contributor
Author
There was a problem hiding this comment.
It's rad since that is what the argument for the claw method: https://github.com/makerdao/dss/blob/master/src/cat.sol#L178
paytonrules
reviewed
Sep 3, 2020
|
|
||
| Expect(dbResult.AddressID).To(Equal(addressID)) | ||
| Expect(dbResult.MsgSender).To(Equal(msgSenderID)) | ||
| Expect(dbResult.Rad).To(Equal("164878299999999999999707170900220955677367419868")) |
Contributor
There was a problem hiding this comment.
Not a big enough number.
paytonrules
approved these changes
Sep 3, 2020
Contributor
paytonrules
left a comment
There was a problem hiding this comment.
I don't understand why it's rad and not litter, but I think that's my confusion not yours.
👍
e29bf00 to
3563ed6
Compare
3563ed6 to
137c970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.