VDB-1599 cat file box [staging]#284
Conversation
7875309 to
0233e05
Compare
8630b14 to
1a6fa1e
Compare
paytonrules
left a comment
There was a problem hiding this comment.
A couple questions that probably reflect more on my ignorance than the code, and you'll probably want to remove commented imports, otherwise 👍
| median_wbtc.StorageTransformerInitializer, | ||
| median_zrx.StorageTransformerInitializer, | ||
| }, | ||
| []storage.TransformerInitializer{}, |
There was a problem hiding this comment.
Did you mean to empty this out?
There was a problem hiding this comment.
I did - was thinking that it would be easier to do a backfill for all of the new cat transformers in one go, than having to change it for each new transformer.
| import ( | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/core/types" | ||
| //"github.com/ethereum/go-ethereum/core" |
There was a problem hiding this comment.
🙈 nice catch
| } | ||
| func catFileChopLumpMethod() string { | ||
| return getOverloadedFunctionSignature(CatABI(), "file", []string{"bytes32", "bytes32", "uint256"}) | ||
| return getOverloadedFunctionSignature(Cat100ABI(), "file", []string{"bytes32", "bytes32", "uint256"}) |
There was a problem hiding this comment.
Just double checking that this is right - this is Cat100 not 110 because there is no chop lump in the new contract correct?
There was a problem hiding this comment.
Yep, that's correct. Though, I think that Cat110 has a file method that has the same signature, so this method could probably be renamed to catFileChopDunkMethod() as part of the VDB-1632 work.
No description provided.