Conversation
392ebbe to
bb795f5
Compare
|
|
||
| var actualIlks []ilkHelpers.IlkSnapshot | ||
| err := db.Select(&actualIlks, `SELECT ilk_identifier, rate, art, spot, line, dust, chop, lump, flip, rho, duty, pip, mat, created, updated FROM api.all_ilks()`) | ||
| err := db.Select(&actualIlks, `SELECT ilk_identifier, rate, art, spot, line, dust, chop, lump, flip, rho, duty, pip, mat, dunk, created, updated FROM api.all_ilks()`) |
There was a problem hiding this comment.
Making sure I understand how we're handling this - we're expecting that we'd see lump be 0 for the new contract, and dunk be 0 for the old contract. Is that right?
There was a problem hiding this comment.
I think we'd expect those values to be null on the contract where they aren't present, although it looks a little different on the actual ilk_snapshot table depending on the history of the ilk - e.g. if a lump was assigned before a dunk, then lump = n and dunk = null. Once dunk is assigned, lump = n and dunk = m. If lump was never assigned before dunk (for a new ilk), then lump = null and dunk = n, etc
There was a problem hiding this comment.
also, if we insert a fake diff to wipe the lump, then we'd expect lump to go to whatever it's assigned to in the fake diff
| BeforeEach(func() { | ||
| test_config.CleanTestDB(db) | ||
| repo = cat.StorageRepository{ContractAddress: test_data.CatAddress()} | ||
| repo = cat.StorageRepository{ContractAddress: test_data.CatV100Address()} |
There was a problem hiding this comment.
Super small thing, but I wonder if we should use CatV110Address for these new storage slot tests, since they are only in the new contract? Not that it probably matters for these specific tests, but it may be helpful for documentation purposes?
There was a problem hiding this comment.
As it stands, this repository includes fields from both contracts (e.g. both lump and dunk). Happy to make the change, but I guess neither contract has all of the values that are included in these tests 🤔
81d0d62 to
42ab9e7
Compare
42ab9e7 to
3831852
Compare
No description provided.