(VDB-1082) bigint primary keys for big tables#272
Merged
Conversation
040c69c to
39cc817
Compare
elizabethengelman
approved these changes
Aug 25, 2020
| msg_sender INTEGER NOT NULL REFERENCES public.addresses (id) ON DELETE CASCADE, | ||
| address_id BIGINT NOT NULL REFERENCES public.addresses (id) ON DELETE CASCADE, | ||
| msg_sender BIGINT NOT NULL REFERENCES public.addresses (id) ON DELETE CASCADE, | ||
| header_id INTEGER NOT NULL REFERENCES public.headers (id) ON DELETE CASCADE, |
Contributor
There was a problem hiding this comment.
Do you think it's worth updating the header id to be a BIGSERIAL (on the header table), and then a BIGINT here?
Contributor
There was a problem hiding this comment.
Also, now just realizing that this would be more a change for the vdb repo.
Contributor
Author
There was a problem hiding this comment.
I'm thinking about skipping that one just because I think we'd need to be syncing multiple networks to have any chance of exhausting the range of ints available, and I feel like supporting that would require more deliberate thought/work elsewhere 🤔
added 2 commits
August 25, 2020 15:05
- minimize potential padding
39cc817 to
12172c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.