Vdb 1592 add address to cat events#268
Merged
elizabethengelman merged 5 commits intostagingfrom Aug 18, 2020
Merged
Conversation
276b3f3 to
a9c4b80
Compare
a9c4b80 to
015b230
Compare
rmulhol
approved these changes
Aug 14, 2020
| biteEvent.ColumnValues[constants.UrnColumn] = urnID | ||
| biteEvent.ColumnValues[event.HeaderFK] = headerID | ||
| biteEvent.ColumnValues[event.LogFK] = logID | ||
| biteEvent.ColumnValues[event.AddressFK] = addressID |
Contributor
There was a problem hiding this comment.
Worth potentially using AssignAddressID here?
Contributor
Author
There was a problem hiding this comment.
yep, nice catch!
015b230 to
57434b9
Compare
57434b9 to
f22096b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: this build failure should be fixed by #266