Skip to content

Assign address helper#267

Merged
elizabethengelman merged 2 commits intostagingfrom
assign-address-helper
Aug 14, 2020
Merged

Assign address helper#267
elizabethengelman merged 2 commits intostagingfrom
assign-address-helper

Conversation

@elizabethengelman
Copy link
Copy Markdown
Contributor

@elizabethengelman elizabethengelman commented Aug 12, 2020

  • add a new AssignAddressID test helper
  • use AssignAddressID helper in event tests
  • use AssignMessageSender in some places that were previously missed

note: this build failure should be fixed by #266

@elizabethengelman elizabethengelman requested review from paytonrules, rmulhol and yaoandrew and removed request for yaoandrew August 12, 2020 14:58
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😤 💪 🎉

Copy link
Copy Markdown
Contributor

@yaoandrew yaoandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰 🕳️ 🤣

@elizabethengelman elizabethengelman merged commit 6ace942 into staging Aug 14, 2020
@elizabethengelman elizabethengelman deleted the assign-address-helper branch August 14, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants