(VDB-1396) Add auction file transformer#221
Merged
Conversation
bcaf06b to
c9771c0
Compare
yaoandrew
reviewed
Jul 7, 2020
environments/docker.toml
Outdated
| type = "eth_event" | ||
| repository = "github.com/makerdao/vdb-mcd-transformers" | ||
| migrations = "db/migrations" | ||
| contracts = ["MCD_FLAP", "MCD_FLIP_BAT_A", "MCD_FLIP_ETH_A", "MCD_FLIP_SAI", "MCD_FLIP_TUSD_A", |
Contributor
There was a problem hiding this comment.
🎗️ just a note to remember to add new collateral types in the rebase.
yaoandrew
reviewed
Jul 7, 2020
| func (t Transformer) ToModels(_ string, logs []core.EventLog, db *postgres.DB) ([]event.InsertionModel, error) { | ||
| var models []event.InsertionModel | ||
| for _, log := range logs { | ||
| err := shared.VerifyLog(log.Log, shared.ThreeTopicsRequired, shared.LogDataNotRequired) |
Contributor
There was a problem hiding this comment.
I forget how we determine how many topics are required, but should this be FourTopicsRequired? Signature [0], msg.sender [1], arg1 [2], and arg2 [3]?
yaoandrew
reviewed
Jul 7, 2020
| }) | ||
| }) | ||
|
|
||
| func auctionFileIntegrationTest(blockNumber int64, contractAddressHex, msgSenderAddressHex, what, data string) { |
yaoandrew
approved these changes
Jul 7, 2020
Contributor
yaoandrew
left a comment
There was a problem hiding this comment.
Nothing merge blocking, just had a few questions.
c9771c0 to
09780fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.