Merged
Conversation
rmulhol
approved these changes
Jul 1, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
LGTM!
Could be cool to drop the benchmarks/query plans in the PR description for additional context - I wouldn't have expected a significant difference between these implementations
Replace DISTINCT with GROUP BY and inner join which reduces the time for me locally against staging from about 900ms to 300ms. Give or take.
1ccac79 to
8134b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace DISTINCT with GROUP BY and inner join which reduces the time for me locally against staging.
For the original query a recent run gives me:
The new version: