Conversation
Contributor
rmulhol
commented
Jul 1, 2020
- add ZRX address to config for existing transformers
- add new transformers for ZRX storage
- update OSM ABIs to match Etherscan
- update constants to include ZRX
- update integration tests where new constants cause failure
paytonrules
approved these changes
Jul 3, 2020
elizabethengelman
approved these changes
Jul 7, 2020
| logrus.Fatalf("No contracts to get ABI for") | ||
| } | ||
| initConfig() | ||
| contractABI := getContractABI(contractNames[0]) |
| @@ -0,0 +1,8 @@ | |||
| package knc_flip | |||
Contributor
There was a problem hiding this comment.
Do we need to also include a ZRX flip initializer?
Contributor
Author
There was a problem hiding this comment.
we already had one due to it existing in earlier Kovan deploys 🎉
| "github.com/makerdao/vdb-mcd-transformers/transformers/storage/median/initializers" | ||
| ) | ||
|
|
||
| var StorageTransformerInitializer = initializers.GenerateStorageTransformerInitializer(constants.GetContractAddress("MEDIAN_WBTC")) |
Contributor
There was a problem hiding this comment.
Should this be getting the MEDIAN_KNC address instead of MEDIAN_WBTC?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.