Skip to content

Move Dockerhub auth env vars to repo settings in Travis#209

Merged
rmulhol merged 1 commit intostagingfrom
env-vars
Jun 15, 2020
Merged

Move Dockerhub auth env vars to repo settings in Travis#209
rmulhol merged 1 commit intostagingfrom
env-vars

Conversation

@eskp
Copy link
Copy Markdown
Contributor

@eskp eskp commented Jun 12, 2020

No description provided.

@eskp eskp requested review from daimesava and grandizzy June 12, 2020 02:13
@@ -35,7 +35,5 @@ env:
matrix:
secure: grptfgF1K2cGb0umoR8XmBwGGEYxa0xu4qxoB31PsAuR5AVi8G5w/8C9sOQUC9bVz7xDaY08i0DXKqzGMyn4YcyXILnECY2V9Nki+EGpRTM5QCyZMpgRqRYRsuy+0d5bf9qK8LFD1fmQMUtjvULoJlUFMTObs//ZJFT5dxnPkwFmDTh2IfH+3xzd53gTuMtJcPfkoqruNckH2z73H025zASMdJe1muUaq05DuI2HEmNKATyHG3xGCj/kLiD8Lx0qT9OwMjLOwJaq2f6aZcbJ56W0gMmw3BLBrXEHPkEPR+dZvRqys8gh+Ga02RPsZNMyQ5dh1ec71zb8mWrBvJTT4uT78g5CwEjpgcBKpo+Yn74t2cWAAiXC3mcvG5Qv1q3X6eDL+dZgdN1oD3tsgCqyhtt72qqukDCcXF7y+SVm2+Bl9LcDkPMURQG3r14E5VV6W1oncTwxRO9c7qpRlcb6hU1A/OP7YwFagviyD68EKXgMPSarCRCEw1KhQ9eR75QIHyFVqxFLT0t5clQfKCifzCGkfmDR5U/rcPzKVrE4uhIUfC7pblpLQIUU/+1bTKBttcuV9/Fu8A28ldaee2hJ2MuqqZgNo0oQ9B4w7V6GaQYgbYiB/SSIC7OUeGuh4pbX3oQyApNtdLMWqXu01+LHg4mRltRQdmHQIMD9scVutN4=
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why we didn't move all vars to Travis settings?

@daimesava daimesava requested a review from rmulhol June 12, 2020 07:25
@daimesava
Copy link
Copy Markdown
Contributor

adding @rmulhol as reviewer here.

Rob, we're rotating secrets for dockerhub and this PR is to switch to the new pair.

@eskp
Copy link
Copy Markdown
Contributor Author

eskp commented Jun 14, 2020

Thanks @rmulhol, I'll let you do the merge as Sava informs me that will trigger a deploy.

@rmulhol rmulhol merged commit 3fd361f into staging Jun 15, 2020
@rmulhol rmulhol deleted the env-vars branch June 15, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants