(VDB-1335) storage transformer verbose errors#198
Merged
Conversation
9e0e712 to
ea51677
Compare
elizabethengelman
approved these changes
Jun 5, 2020
added 11 commits
June 8, 2020 19:00
- Also consolidate duplicated functions that call it
ea51677 to
53ee6e0
Compare
- Also add fork where missing in cmd/backfillUrns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to provide more detailed error messages when there's a failure in storage transformer execution. In general, all logs should now provide specific info about what data they're managing if there's an error.
I made a few quick changes to squash some complaints from the linter, though they did end up bloating the diff more than I would have hoped. These include: