Add DIFF_BLOCK_FROM_HEAD_OF_CHAIN to execute docker startup script#184
Add DIFF_BLOCK_FROM_HEAD_OF_CHAIN to execute docker startup script#184elizabethengelman merged 4 commits intostagingfrom
Conversation
7539053 to
ed510a3
Compare
| exit 1 | ||
| fi | ||
|
|
||
| DIFF_STARTING_BLOCK="-1" |
There was a problem hiding this comment.
Not sure if this is the best approach for handling this, so would be totally up for changing it up if folks have ideas!
There was a problem hiding this comment.
This approach makes sense to me 👍
Seems like someone running the binary directly could just omit that flag, but if we're always including the flag then I like having a default. My only thought would be wondering if we could use an env var instead of a flag (so that it was fully optional and didn't need to be in the dockerfiles at all), but I think that makes it harder to set a default - and potentially means we'd need to synchronize deploying this with a modification to our configured env vars
a2893b0 to
7955289
Compare
go.mod
Outdated
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/vulcanize/go-ethereum v0.0.0-20190731183759-8e20673bd101 | ||
|
|
||
| replace github.com/makerdao/vulcanizedb => github.com/makerdao/vulcanizedb v0.0.14-rc.1.0.20200430184332-ecfa2869a661 |
There was a problem hiding this comment.
Once sky-ecosystem/vulcanizedb#84 is merged, I was thinking of cutting a new VDB version and using that on line 11 instead of replacing the version.
There was a problem hiding this comment.
Not opposed to cutting a release and updating that way, but I think we could also solve this matter in the short term by running go get github.com/makerdao/vulcanizedb@modify-unchecked-diffs-query. Maybe nice to just modify the import directly instead of using a replace?
rmulhol
left a comment
There was a problem hiding this comment.
LGTM!
Would be a fan of updating the dep via go get rather than a replace unless that runs into problems
| exit 1 | ||
| fi | ||
|
|
||
| DIFF_STARTING_BLOCK="-1" |
There was a problem hiding this comment.
This approach makes sense to me 👍
Seems like someone running the binary directly could just omit that flag, but if we're always including the flag then I like having a default. My only thought would be wondering if we could use an env var instead of a flag (so that it was fully optional and didn't need to be in the dockerfiles at all), but I think that makes it harder to set a default - and potentially means we'd need to synchronize deploying this with a modification to our configured env vars
go.mod
Outdated
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/vulcanize/go-ethereum v0.0.0-20190731183759-8e20673bd101 | ||
|
|
||
| replace github.com/makerdao/vulcanizedb => github.com/makerdao/vulcanizedb v0.0.14-rc.1.0.20200430184332-ecfa2869a661 |
There was a problem hiding this comment.
Not opposed to cutting a release and updating that way, but I think we could also solve this matter in the short term by running go get github.com/makerdao/vulcanizedb@modify-unchecked-diffs-query. Maybe nice to just modify the import directly instead of using a replace?
| eventLogs, getLogsErr := eventLogRepository.GetUntransformedEventLogs() | ||
|
|
||
| logCount := getLogCount(db) | ||
| eventLogs, getLogsErr := eventLogRepository.GetUntransformedEventLogs(0, logCount) |
7955289 to
d47308b
Compare
407a18f to
3adc753
Compare
3adc753 to
f572896
Compare
companion PR to sky-ecosystem/vulcanizedb#84