Skip to content

Vdb 1292 log median price#183

Merged
yaoandrew merged 3 commits intostagingfrom
vdb-1292-logMedianPrice
Apr 30, 2020
Merged

Vdb 1292 log median price#183
yaoandrew merged 3 commits intostagingfrom
vdb-1292-logMedianPrice

Conversation

@yaoandrew
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we can merge when we get the config files + transformerExporter.go updated - and would ideally like an address_id on the table or some other way of distinguishing the ilk

log_id BIGINT NOT NULL REFERENCES public.event_logs (id) ON DELETE CASCADE,
val numeric,
age numeric,
UNIQUE (header_id, log_id)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this will be pointed at multiple contracts, probably want to put an address_id on here to know which ilk's median price we're dealing with.

Also - looks like we're missing config updates to include the transformer and specify what contracts it's watching

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... I force pushed a commit with these yesterday that doesn't seem to have gone through. Let me figure that out and get an address_id on there. That makes sense to figure out which ilk it is.

@yaoandrew yaoandrew force-pushed the vdb-1292-logMedianPrice branch 2 times, most recently from 57a0379 to 6f6a1dd Compare April 30, 2020 20:15
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yaoandrew yaoandrew force-pushed the vdb-1292-logMedianPrice branch from 6f6a1dd to aa4d5af Compare April 30, 2020 23:06
@yaoandrew yaoandrew merged commit 77f4902 into staging Apr 30, 2020
@yaoandrew yaoandrew deleted the vdb-1292-logMedianPrice branch April 30, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants