Add log buy enabled event transformer#177
Merged
Conversation
rmulhol
reviewed
Apr 24, 2020
Contributor
There was a problem hiding this comment.
LGTM but I'd be reluctant to merge right now (and trigger a rescan of all blocks) if there are no matching logs on mainnet. Also curious about the LogMatchingEnabled stuff - do we need a full transformer for that? Would have no problem rolling that into this PR if so.
Not saying we should close the issue though - I think we should merge whenever it can go in alongside another PR that will find new events
rmulhol
approved these changes
Apr 28, 2020
rmulhol
reviewed
Apr 28, 2020
| ) | ||
|
|
||
| var ( | ||
| //TODO Updqte with real data |
Contributor
There was a problem hiding this comment.
This totally doesn't matter but if you need to amend a commit to trigger the build you could fix the typo here
eeb203f to
a3da40e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.