Skip to content

Remove log discards in test suites#172

Merged
rmulhol merged 1 commit intostagingfrom
unused-imports
Apr 28, 2020
Merged

Remove log discards in test suites#172
rmulhol merged 1 commit intostagingfrom
unused-imports

Conversation

@rmulhol
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol commented Apr 20, 2020

  • No longer necessary since logging happens higher up
  • Also rename suites to be more verbose

Copy link
Copy Markdown
Contributor

@yaoandrew yaoandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good -494 lines 🥇

- No longer necessary since logging happens higher up
- Also rename suites to be more verbose
Copy link
Copy Markdown
Contributor

@paytonrules paytonrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regret that I have but one shipit to give.

@rmulhol rmulhol merged commit e9a3247 into staging Apr 28, 2020
@rmulhol rmulhol deleted the unused-imports branch April 28, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants