Merged
Conversation
- This does not have the SQL to go with it. Only the unit test and the transformer.
rmulhol
suggested changes
Apr 20, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Nice work! LGTM as soon as the migration timestamp is updated 👍
| ColumnValues: event.ColumnValues{ | ||
| event.HeaderFK: LogMinSellEventLog.HeaderID, | ||
| event.LogFK: LogMinSellEventLog.ID, | ||
| // pay gem address id |
Contributor
There was a problem hiding this comment.
if we're adding a comment for columns that aren't included here (I dig it), I'd prob put the address id on a separate line to make clear that it's a separate field (and not just the address id for the pay gem)
Contributor
Author
There was a problem hiding this comment.
"I learned it from watching you Dad" - I mean I was trying to follow along with what you did in LogMake.
ColumnValues: event.ColumnValues{
event.HeaderFK: LogMakeEventLog.HeaderID,
event.LogFK: LogMakeEventLog.ID,
// Oasis contract address id
constants.OfferId: "811648",
constants.PairColumn: "0xcdd6659bca20e2b28ea10ead902280762ac8977c84459a152f90e561d50edf8c",
// Maker address id
// Pay gem address id
// Buy gem address id
constants.PayAmtColumn: "64380000000000000000",
constants.BuyAmtColumn: "14258238600000000000000",
constants.TimestampColumn: "1581143548",
},
Contributor
There was a problem hiding this comment.
// Oasis contract address id 👀
Contributor
There was a problem hiding this comment.
But also do as I say not as I do! 😅
d3a8bf9 to
a388b49
Compare
rmulhol
approved these changes
Apr 21, 2020
- Remove some unintentionally checked in comments. - Remove the Id from the LogMinSellEntity
66a7984 to
5f17d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://makerdao.atlassian.net/secure/RapidBoard.jspa?rapidView=17&projectKey=VDB&modal=detail&selectedIssue=VDB-1276