Add a LogKill event transformer#167
Merged
elizabethengelman merged 3 commits intostagingfrom Apr 20, 2020
Merged
Conversation
rmulhol
suggested changes
Apr 17, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Will need to bump the migration timestamp but otherwise LGTM!
| Expect(dbResult.AddressID).To(Equal(expectedAddressID)) | ||
| }) | ||
|
|
||
| FIt("fetches and transforms a LogKill event for OASIS_MATCHING_MARKET_TWO contract", func() { |
Contributor
There was a problem hiding this comment.
Think we need to swap out the FIt to fix the build
Contributor
Author
There was a problem hiding this comment.
🤦♀️ nice catch! Also good to know that the build fails when there's a focus!
| expectedModel.ColumnValues[constants.PayGemColumn] = payGemAddressId | ||
| expectedModel.ColumnValues[constants.BuyGemColumn] = buyGemAddressId | ||
|
|
||
| Expect(models).To(Equal([]event.InsertionModel{expectedModel})) |
Contributor
There was a problem hiding this comment.
This reads much nicer than the transformer tests I've been writing 😅
May open up a small PR to do address ID assignments this way elsewhere 👍
| constants.BuyGemColumn, | ||
| constants.PayAmtColumn, | ||
| constants.BuyAmtColumn, | ||
| constants.TimestampColumn, |
| CREATE INDEX log_kill_index | ||
| ON maker.log_kill (log_id); | ||
| CREATE INDEX log_kill_address_index | ||
| ON maker.log_kill (address_id); |
Contributor
There was a problem hiding this comment.
May want indexes on the maker/pay_gem/buy_gem FKs as well?
e1b0760 to
93118b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.