Update offer_id to type NUMERIC in log_item_update table#160
Merged
elizabethengelman merged 1 commit intostagingfrom Apr 14, 2020
Merged
Update offer_id to type NUMERIC in log_item_update table#160elizabethengelman merged 1 commit intostagingfrom
elizabethengelman merged 1 commit intostagingfrom
Conversation
13761b8 to
450bc89
Compare
nice catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking more at
LogItemUpdatethe offer id is auintwhich is an alias touint256: https://solidity.readthedocs.io/en/v0.5.3/types.html#integers in solidity. So this field should be bumped up to aNUMERICto make sure it's big enough to fit a number that is potentially 32bytes.