Skip to content

(VDB-1267) vat hope/nope#159

Merged
rmulhol merged 3 commits intostagingfrom
vdb-1267-vat-hope
Apr 13, 2020
Merged

(VDB-1267) vat hope/nope#159
rmulhol merged 3 commits intostagingfrom
vdb-1267-vat-hope

Conversation

@rmulhol
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol commented Apr 13, 2020

Shoutout to @gslaughl for making this super easy with the vat_auth transformer 🎉

gslaughl
gslaughl approved these changes Apr 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@gslaughl gslaughl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good idea re-using the vat_auth transformer.

Edit: looks like we need a line in transformerExporter though ;)

@rmulhol rmulhol force-pushed the vdb-1267-vat-hope branch 2 times, most recently from d6a5a3e to c3100f2 Compare April 13, 2020 18:29
@rmulhol rmulhol force-pushed the vdb-1267-vat-hope branch from c3100f2 to 3dc2197 Compare April 13, 2020 18:32
@rmulhol rmulhol force-pushed the vdb-1267-vat-hope branch from 3dc2197 to 9068c0a Compare April 13, 2020 18:33
@rmulhol rmulhol merged commit 4bfc61f into staging Apr 13, 2020
@rmulhol rmulhol deleted the vdb-1267-vat-hope branch April 13, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paytonrules paytonrules Awaiting requested review from paytonrules

@yaoandrew yaoandrew Awaiting requested review from yaoandrew

@elizabethengelman elizabethengelman Awaiting requested review from elizabethengelman

1 more reviewer

@gslaughl gslaughl gslaughl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmulhol @gslaughl