Skip to content

VDB-1227 Median drop event transformer#145

Merged
yaoandrew merged 11 commits intostagingfrom
vdb-1227-median-drop
Apr 10, 2020
Merged

VDB-1227 Median drop event transformer#145
yaoandrew merged 11 commits intostagingfrom
vdb-1227-median-drop

Conversation

@yaoandrew
Copy link
Copy Markdown
Contributor

@yaoandrew yaoandrew commented Mar 17, 2020

I'll rebase this after Gabe merges #143. Sorry for the clutter for now but it made sense to piggyback off that for some his fine work on medianizer.

@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch 2 times, most recently from 00fe3ba to f8a94f5 Compare March 25, 2020 19:53
@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch from f8a94f5 to 4c28f3f Compare March 26, 2020 22:20
Copy link
Copy Markdown
Contributor

@gslaughl gslaughl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but LGTM

@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch 2 times, most recently from 4adb34e to 1f1a364 Compare March 31, 2020 05:03
@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch 4 times, most recently from b858d2a to e6a2fea Compare April 7, 2020 20:32
@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch from e6a2fea to e451452 Compare April 7, 2020 21:36
@yaoandrew yaoandrew requested a review from rmulhol April 7, 2020 21:52
Copy link
Copy Markdown
Contributor

@gslaughl gslaughl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch 6 times, most recently from 07ec6f0 to 7182cb3 Compare April 9, 2020 19:38
@yaoandrew yaoandrew requested a review from rmulhol April 9, 2020 19:55
@yaoandrew yaoandrew force-pushed the vdb-1227-median-drop branch from 7182cb3 to eb481de Compare April 10, 2020 00:16
@yaoandrew yaoandrew merged commit f396fe7 into staging Apr 10, 2020
@yaoandrew yaoandrew deleted the vdb-1227-median-drop branch April 10, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants