(VDB-1218) Add function for inserting headers#144
Merged
Conversation
Contributor
rmulhol
commented
Mar 11, 2020
- Compatibility with upstream vdb changes
- Compatibility with upstream vdb changes
rmulhol
commented
Mar 11, 2020
|
|
||
| COMMENT ON TABLE maker.osm_change IS 'Note event emitted when change is called on OSM/PIP contract(s)'; | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Idk why this is showing up as part of the PR but seems like maybe a migration was updated without the schema getting a corresponding update as we removed comments?
rmulhol
commented
Mar 11, 2020
| github.com/jmoiron/sqlx v0.0.0-20181024163419-82935fac6c1a | ||
| github.com/magiconair/properties v1.8.0 | ||
| github.com/makerdao/vulcanizedb v0.0.13-rc.2 | ||
| github.com/makerdao/vulcanizedb v0.0.13-rc.2.0.20200309155515-0dcc44e856be |
Contributor
Author
There was a problem hiding this comment.
will switch back to staging and/or a release if we get it merged on the vdb side
yaoandrew
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.