(VDB-1228) Median kiss + diss transformers#143
Conversation
c0b8d54 to
cd66873
Compare
c50fa00 to
0934498
Compare
| CREATE TABLE maker.bid_event | ||
| ( | ||
| log_id BIGINT PRIMARY KEY REFERENCES event_logs (id) ON DELETE CASCADE, | ||
| log_id BIGINT PRIMARY KEY REFERENCES event_logs (id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED, |
There was a problem hiding this comment.
This line fixes the flaky test we've been seeing, by specifying that the CASCADE DELETE should happen at the end of the transaction. This way we won't run into the issue where a trigger is trying to update a row that was already deleted, because the row won't have been deleted yet.
Here are some docs about deferrable constraints if you're interested
There was a problem hiding this comment.
Don't think we want to modify the earlier migration here. Is it possible to update this column in a new migration?
There was a problem hiding this comment.
Haha oh yeah 🤦♂
Can def put this into a separate migration
|
|
||
|
|
||
| -- +goose Down | ||
| DROP TABLE maker.median_kiss_single; |
There was a problem hiding this comment.
Not an issue right now but if this is merged after the backfill stuff then we'll need updated timestamps on here to make sure they come after that. Mostly just posting as a general reminder to make sure all new migrations are the latest against staging for every PR
0934498 to
7baa4ad
Compare
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| // TODO: Update once a diss event has happened |
There was a problem hiding this comment.
Looking in etherscan I still can't find any diss events, unfortunately
No description provided.