Conversation
|
|
||
| import ( | ||
| "database/sql" | ||
| "github.com/makerdao/vulcanizedb/libraries/shared/factories/event" |
There was a problem hiding this comment.
Obv not merge blocking, but not sure where we landed on this... using goimports and calling it a day? 😬
| const ( | ||
| logDataRequired = true | ||
| numTopicsRequired = 4 | ||
| logDataRequired = true |
| }, | ||
| ForeignKeyValues: shared.ForeignKeyValues{ | ||
| constants.AddressFK: DentHeaderSyncLog.Log.Address.Hex(), | ||
| // constants.AddressColumn |
There was a problem hiding this comment.
Sanity preservation, it should be there but we can't assert against it since it depends on the DB state when the tests run :)
transformers/test_data/dent.go
Outdated
| dent.Id: dentBidId, | ||
| dent.Lot: dentLot, | ||
| dent.Bid: dentBid, | ||
| constants.HeaderFK: DentHeaderSyncLog.HeaderID, |
There was a problem hiding this comment.
Not sure when to use one vs the other or if we need both but could we potentially use event.HeaderFK from vulcanizedb/libraries/shared/factories
(VDB-354) queue unrecognized diffs
VDB-429 Update Frob event transformer
| ) | ||
|
|
||
| type DentRepository struct { | ||
| type Repository struct { |
There was a problem hiding this comment.
Why are we keeping a transformer specific repository at all? Seems like we could just initialize the shared factories/transformer with a database connection and pass that directly to event.Create. Then we could remove the Repository from the initializer entirely, right?
There was a problem hiding this comment.
Available for whoever wants to shepherd the dual PRs :) We just decided to do it in steps a while back, moving stuff over, then removing the repos.
9222613 to
b5a425b
Compare
b5a425b to
5569242
Compare
5569242 to
ac41567
Compare
No description provided.