Adds gomoderator docker to travis build#129
Merged
Conversation
55ce869 to
81cef62
Compare
81cef62 to
6517e3e
Compare
yaoandrew
commented
Feb 19, 2020
87ad456 to
1ec37e9
Compare
rmulhol
reviewed
Mar 4, 2020
7b9cf68 to
1205734
Compare
rmulhol
reviewed
Mar 5, 2020
dockerfiles/gomoderator/Dockerfile
Outdated
|
|
||
| WORKDIR /go/src/github.com/makerdao | ||
| RUN git clone https://github.com/makerdao/vulcanizedb.git | ||
| RUN git clone https://github.com/makerdao/vdb-mcd-transformers.git |
Contributor
There was a problem hiding this comment.
I don't think we need to clone this repo (and probably don't want to so we avoid being on the wrong branch).
Instead maybe we can just COPY . . (may want to enter the appropriate workdir first, e.g. just do it after line 14)
6963621 to
5182f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a
Dockerfilethat is used in the.travis.yml.It should rungomoderatoracross both repos. Exit codes have been updated to be more explicit in this PR:sky-ecosystem/vulcanizedb#49