(VDB-1164) Copy over migrations from vDB#128
Merged
Conversation
rmulhol
approved these changes
Feb 18, 2020
| network_id NUMERIC, | ||
| eth_node_id VARCHAR(128), | ||
| UNIQUE (genesis_block, network_id, eth_node_id) | ||
| UNIQUE (genesis_block, network_id, eth_node_id, client_name) |
Contributor
There was a problem hiding this comment.
Should have mentioned this on the other PR but heads up that we need to avoid modifying earlier migrations starting asap if we're working against a deployed db - otherwise the changes won't take hold.
Contributor
Author
There was a problem hiding this comment.
🤦♂ oh boy, that's gonna take some getting used to haha
| eth_node_id VARCHAR(128), | ||
| UNIQUE (genesis_block, network_id, eth_node_id) | ||
| UNIQUE (genesis_block, network_id, eth_node_id, client_name) | ||
| ); |
Contributor
There was a problem hiding this comment.
Perhaps worth modifying the go.mod to point at the branch with these changes (unless they're already on staging?) so that CI verifies any other changes on the vdb side avoid causing any test failures
f71d45b to
f09f220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to sky-ecosystem/vulcanizedb#46