(VDB-1199) Add extractDiffs to docker-compose#122
Merged
Conversation
Contributor
rmulhol
commented
Feb 12, 2020
- Also remove unnecessary env data from other images
4ca35a1 to
9a1c5ff
Compare
| command: ["./wait-for-it.sh", "db:5432", "--strict", "--", "./startup_script.sh"] | ||
| restart: unless-stopped | ||
|
|
||
| extract-diffs: |
|
|
||
| execute: | ||
| image: makerdao/vdb-execute:latest # (needs wait-for-it.sh) | ||
| env_file: mainnet-1.0.1.env |
Contributor
There was a problem hiding this comment.
I think I'm missing something - how are we getting the contract addresses, etc in without this env file now?
Contributor
Author
There was a problem hiding this comment.
Moved to config - apparently the actual deployment setup requires some cumbersome detail for env vars, so moving toward minimizing the details that need to remain in the env
9a1c5ff to
99c5671
Compare
Contributor
Author
|
@elizabethengelman any blockers to getting your approval for this one? |
Contributor
|
@rmulhol whoops, so sorry, meant to approve earlier! |
99c5671 to
f9d21e3
Compare
- Also remove unnecessary env data from other images
f9d21e3 to
17f9fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.