Merged
Conversation
dbd1945 to
229bb4a
Compare
rmulhol
approved these changes
Feb 11, 2020
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Haven't run this myself but LGTM if it works!
Would potentially be cool to consider verifying the other config files as well, but I'm fine with creating a new story for that if it's a hassle
| fi | ||
|
|
||
| for ((i=0; i<${#exportedTransformers[@]}; i++)); do | ||
| if [ ${exportedTransformers[$i]} != ${configTransformers[$i]} ]; then |
Contributor
There was a problem hiding this comment.
Does this depend on the order of the transformers being the same between environments/docker.toml and plugins/transformerExporter.go?
Contributor
Author
There was a problem hiding this comment.
It does. I sort both collections when I create them. I guess the O(n**2) solution wouldn't be terrible since we don't expect either collection to be large and then we wouldn't have to worry about order.
229bb4a to
b483336
Compare
b483336 to
f5d6af3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should check the docker.toml file vs the transformerExporter.go file. Should we potentially pass the config file in via env var? Its a pretty basic check. Other enhancements could be checking the toml file for each transformerName listed that there is a corresponding exporter block.