Resolve auth endpoint dynamically and use dedicated pods#438
Merged
Conversation
Closed
…list-versions APIs
383799f to
b677c78
Compare
This was referenced Feb 16, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for "pod"-specific App Store endpoints, enhancing how requests are routed and authenticated. The main changes involve fetching the correct authentication endpoint dynamically, propagating the "pod" information through the login flow, and updating all relevant requests to use the pod-specific host if available. Comprehensive tests have been added for these new behaviors.
Pod-aware endpoint support:
Bagmethod to theAppStoreinterface and its implementation, which fetches endpoint definitions (including the authentication endpoint) from the App Store "bag" service. (pkg/appstore/appstore.go,pkg/appstore/appstore_bag.go, [1] [2]Accountstruct. (cmd/auth.go,pkg/appstore/account.go,pkg/appstore/appstore_login.go, [1] [2] [3] [4] [5] [6] [7] [8] [9]Pod-specific request routing:
Account.Podfield is set, ensuring requests are routed correctly for users assigned to a particular pod. (pkg/appstore/appstore_download.go,pkg/appstore/appstore_get_version_metadata.go,pkg/appstore/appstore_list_versions.go, [1] [2] [3] [4]Testing improvements:
Bagmethod, as well as tests to verify that pod-specific hosts are used in download, get version metadata, and list versions requests. (pkg/appstore/appstore_bag_test.go,pkg/appstore/appstore_download_test.go,pkg/appstore/appstore_get_version_metadata_test.go,pkg/appstore/appstore_list_versions_test.go, [1] [2] [3] [4]Accountstruct and in request routing. (pkg/appstore/appstore_login_test.go, [1] [2] [3] [4] [5]