Skip to content

[MAISTRA-1744] Route Annotations Documentation Update#158

Merged
mergify[bot] merged 4 commits intomaistra:maistra-2.0from
David-Elizondo:feature/route-annoations
Aug 12, 2020
Merged

[MAISTRA-1744] Route Annotations Documentation Update#158
mergify[bot] merged 4 commits intomaistra:maistra-2.0from
David-Elizondo:feature/route-annoations

Conversation

@David-Elizondo
Copy link
Copy Markdown

@David-Elizondo David-Elizondo commented Aug 12, 2020 •
edited
Loading

Adding documentation in reference to propagating route annotations in IOR. Feature will be added from these PRs:

Version 1.1: maistra/ior#11
Version 2.0: maistra/istio#158

https://issues.redhat.com/browse/MAISTRA-1744

@maistra-bot
Copy link
Copy Markdown

maistra-bot commented Aug 12, 2020

Hi @rtselizondo. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@David-Elizondo David-Elizondo mentioned this pull request Aug 12, 2020
Closed
brian-avery
brian-avery reviewed Aug 12, 2020
View reviewed changes
@David-Elizondo David-Elizondo mentioned this pull request Aug 12, 2020
Closed
@brian-avery
Copy link
Copy Markdown
Contributor

brian-avery commented Aug 12, 2020

/retest

@brian-avery
Copy link
Copy Markdown
Contributor

brian-avery commented Aug 12, 2020

That failure is being fixed in #161.

@brian-avery
Copy link
Copy Markdown
Contributor

brian-avery commented Aug 12, 2020

/retest

@maistra-bot
Copy link
Copy Markdown

maistra-bot commented Aug 12, 2020

@rtselizondo: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jwendell
jwendell requested changes Aug 12, 2020
View reviewed changes
@brian-avery
Copy link
Copy Markdown
Contributor

brian-avery commented Aug 12, 2020

/retest

@mergify mergify bot merged commit ade0992 into maistra:maistra-2.0 Aug 12, 2020
@brian-avery
Copy link
Copy Markdown
Contributor

brian-avery commented Aug 13, 2020

/cherry-pick maistra-1.1

@maistra-bot maistra-bot mentioned this pull request Aug 13, 2020
Merged
@maistra-bot
Copy link
Copy Markdown

maistra-bot commented Aug 13, 2020

@brian-avery: new pull request created: #162

Details

In response to this:

/cherry-pick maistra-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwendell jwendell jwendell approved these changes

+1 more reviewer

@brian-avery brian-avery brian-avery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherrypick/maistra-1.1 ok-to-test okay to merge size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@David-Elizondo @maistra-bot @brian-avery @jwendell