Fixes MAISTRA-2550: Port of https://github.com/envoyproxy/envoy/pull/…#102
Merged
maistra-bot merged 1 commit intomaistra:maistra-2.1from Aug 3, 2021
Merged
Conversation
…e ServerFactoryContext is passed to bootstrap extensions, it is only partially initialized. Specifically, attempting to access the cluster manager will cause a nullptr access (and hence a crash) This PR splits the creation and initialized to 2 seperate fucntions. Early creation is required to not break the `default_socket_interface` feature. Once created, the extension will receive the ServerFactoryContext in a different callback (the newly added `serverInitialized`), once they are fully initialized. Commit Message: Fix a crash that happens when bootstrap extensions perform http calls. Additional Description: Risk Level: Low (small bug-fix) Testing: Unit tests updated; tested manually with the changes as well. Docs Changes: N/A Release Notes: N/A Fixes envoyproxy/envoy#14420 Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
Contributor
Author
|
This is an almost cherry-pick -- no changes from the original were required. |
jwendell
approved these changes
Jul 30, 2021
Member
jwendell
left a comment
There was a problem hiding this comment.
LGTM, Only the commit title is weird. Try to keep it short. Details could go after the break line.
oschaaf
approved these changes
Aug 1, 2021
Contributor
oschaaf
left a comment
There was a problem hiding this comment.
I agree with John on his remark about the commit title, but other then that LGTM
Member
|
/retest |
1 similar comment
Member
|
/retest |
Contributor
Author
|
Agree re: commit message; wanted to keep it the same as upstream to minimise any possible confusion. Thanks for reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…14478. Currently when the ServerFactoryContext is passed to bootstrap extensions, it is only partially initialized. Specifically, attempting to access the cluster manager will cause a nullptr access (and hence a crash)
This PR splits the creation and initialized to 2 seperate fucntions. Early creation is required to not break the
default_socket_interfacefeature. Once created, the extension will receive the ServerFactoryContext in a different callback (the newly addedserverInitialized), once they are fully initialized.Commit Message:
Fix a crash that happens when bootstrap extensions perform http calls.
Additional Description:
Risk Level: Low (small bug-fix)
Testing: Unit tests updated; tested manually with the changes as well.
Docs Changes: N/A
Release Notes: N/A
Fixes envoyproxy/envoy#14420
Signed-off-by: Yuval Kohavi yuval.kohavi@gmail.com
Signed-off-by: Dmitri Dolguikh ddolguik@redhat.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]