Skip to content

Fix hasAria() docs and add hasNoAria() and lacksAria() aliases#1481

Merged
Turbo87 merged 4 commits intomainmatter:masterfrom
jamescdavis:fix_doesNotHaveAria_link
Mar 10, 2022
Merged

Fix hasAria() docs and add hasNoAria() and lacksAria() aliases#1481
Turbo87 merged 4 commits intomainmatter:masterfrom
jamescdavis:fix_doesNotHaveAria_link

Conversation

@jamescdavis
Copy link
Contributor

@jamescdavis jamescdavis commented Mar 2, 2022 •
edited
Loading

This:

  • updates the link in hasAria()'s doc block from hasNoAria() to doesNotHaveAria()
  • adds hasNoAria() and lacksAria() as aliases for doesNotHaveAria() to be consistent with hasNoAttribute() and lacksAttribute() aliases for doesNotHaveAttribute() (and other doesNotHave assertions)
  • updates the example in doesNotHaveAttribute() to use doesNotHaveAttribute() instead of its alias hasNoAttribute()

Note: I can't get pnpm run docs to succeed so this PR doesn't update API.md

@Turbo87
Copy link
Contributor

Turbo87 commented Mar 2, 2022

what do you think about adding hasNoAria() (similar to hasNoAttribute()) instead?

@jamescdavis
Copy link
Contributor Author

jamescdavis commented Mar 2, 2022

I think it makes sense to add hasNoAria() and lacksAria() as aliases to be consistent with the hasNoAttribute() and lacksAttribute() aliases for doesNotHaveAttribute().

@jamescdavis jamescdavis force-pushed the fix_doesNotHaveAria_link branch from 49a69c9 to 98841f0 Compare March 3, 2022 18:22
@jamescdavis jamescdavis changed the title docs: s/hasNoAria/doesNotHaveAria/ s/hasNoAria/doesNotHaveAria/ in hasAria in docs and add hasNoAria/lacksAria aliases Mar 3, 2022
@jamescdavis
Copy link
Contributor Author

jamescdavis commented Mar 3, 2022

@Turbo87 I've expanded this PR to add those aliases.

Turbo87
Turbo87 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@Turbo87 Turbo87 changed the title s/hasNoAria/doesNotHaveAria/ in hasAria in docs and add hasNoAria/lacksAria aliases Fix hasAria() docs and add hasNoAria() and lacksAria() aliases Mar 10, 2022
@Turbo87 Turbo87 merged commit bcb67e0 into mainmatter:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Turbo87 Turbo87 Turbo87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamescdavis @Turbo87