enhancement for individual nonspam quarantine keeping#1281
Merged
endelwar merged 2 commits intomailwatch:1.2from Jul 25, 2023
Merged
enhancement for individual nonspam quarantine keeping#1281endelwar merged 2 commits intomailwatch:1.2from
endelwar merged 2 commits intomailwatch:1.2from
Conversation
I found it useful to have quarantine keeping days independently configured for nonspam. So with this you can for example keep the spams for 30 days but the nonspams only for let's say 10 days. On busy systems this can save performance and drive space. The other way around is also possible if needed: e.g. keep spam 20 days and nonspam 40 days.
endelwar
reviewed
Jul 24, 2023
| { | ||
| $oldest = date('U', strtotime('-' . QUARANTINE_DAYS_TO_KEEP . ' days')); | ||
| $oldestspam = date('U', strtotime('-' . QUARANTINE_DAYS_TO_KEEP . ' days')); | ||
| $oldestnonspam = date('U', strtotime('-' . QUARANTINE_DAYS_TO_KEEP_NONSPAM . ' days')); |
Member
There was a problem hiding this comment.
There should be a check here to confirm if constant exists, or fallback on QUARANTINE_DAYS_TO_KEEP
Contributor
Author
There was a problem hiding this comment.
sure, I will add that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it useful to have quarantine keeping days independently configured for nonspam mails.
Of course this is only relevant if you also store nonspams like this:
Non Spam Actions = store-nonspam ...So with this enhancement you can for example keep the spams for 30 days but the nonspams only for let's say 10 days.
On busy systems this can save performance and drive space.
The other way around is also possible if needed: e.g. keep spam 20 days and nonspam 40 days.