Skip to content

enhancement for optionally hiding nonspams on quarantine display#1268

Merged
endelwar merged 2 commits intomailwatch:1.2from
dneuhaeuser:quarantine
Jul 24, 2023
Merged

enhancement for optionally hiding nonspams on quarantine display#1268
endelwar merged 2 commits intomailwatch:1.2from
dneuhaeuser:quarantine

Conversation

@dneuhaeuser
Copy link
Copy Markdown
Contributor

@dneuhaeuser dneuhaeuser commented Nov 7, 2022

enhance quarantine.php display to regard all HIDE_... configuration options like quarantine_report.inc.php does.

this is especially useful when you have Mailscanner configured like this:
Non Spam Actions = store-nonspam ...

Then you can get only the relevant quarantine to display with mailwatch config:
define('HIDE_UNKNOWN', true);

enhance quarantine.php display to regard all HIDE configuration options like quarantine_report.inc.php does.
@dneuhaeuser dneuhaeuser marked this pull request as ready for review November 7, 2022 17:24
@ghost
Copy link
Copy Markdown

ghost commented Mar 12, 2023

I don't think this is desired behavior for some folks (myself included). Although I don't want certain things in the quarantine report, I want to be able to see all mail in the UI. Perhaps need an option to toggle this functionality so that both behaviors can be achieved.

@dneuhaeuser
Copy link
Copy Markdown
Contributor Author

So, you have HIDE_UNKNOWN = true but want to see the nonspam mails on the quarantine page?

My users actually found this very confusing. They only go to the quarantine page to release spam or bad mails and expect to see only the mails which where reported by quarantine_report there.

All mails are always visible in message listing and message operations, to inspect non-spams for example.

Where is the point to show non-spams in the quarantine?

@ghost
Copy link
Copy Markdown

ghost commented Mar 13, 2023

I agree that may be desirable for users. I think there should be a setting that enables this desired behavior as an option so that those that don't want that behavior can disable it.

@dneuhaeuser
Copy link
Copy Markdown
Contributor Author

dneuhaeuser commented Jul 8, 2023

I added a configuration parameter to enable or disable whether the hide filters are applied to the quarantine page.

@dneuhaeuser dneuhaeuser changed the title enhance quarantine display enhancement for optionally hiding nonspams on quarantine display Jul 8, 2023
@endelwar endelwar merged commit 8805fa2 into mailwatch:1.2 Jul 24, 2023
@endelwar
Copy link
Copy Markdown
Member

Thanks Dennis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants