improve performance of mailwatch_milter_relay.php#1266
Merged
endelwar merged 2 commits intomailwatch:1.2from Jul 24, 2023
Merged
improve performance of mailwatch_milter_relay.php#1266endelwar merged 2 commits intomailwatch:1.2from
endelwar merged 2 commits intomailwatch:1.2from
Conversation
$i needs to be decreased in for-loops after array_splice, otherwise we are skipping the next array element. removed useless global improved debug logging
|
Very nice! I'll give this a test drive as well |
|
This is good. |
Contributor
Author
|
can we merge this one or do you want any further changes? |
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the code part which executes the SQL commands does not need to run after each line from the logfile is processed.
instead it is sufficient to run SQL statements once after logfile is analyzed and relevant data was read into $idqueue array.
so I moved this part into a separate function.
this is a quite simple but very performance-effective change.