Conversation
… settings persistent after logout.
…nt (ie. login with different user)
dkotter
approved these changes
Oct 2, 2024
Collaborator
QA Update ✅I have verified this PR in the I tested the following on this branch:
Another_account.movSeting.persistent.movTesting Environment Details
Steps to Test- As mentioned in the PR description.
|
qasumitbagthariya
approved these changes
Oct 8, 2024
Collaborator
Regression / Smoke Test Report ✅I have verified this PR in the smoke-test branch and it is working as expected. Testing Environment Details
Next Step- Ready to Merge 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
As reported internally in Slack, when logging out of the Mailchimp account, the settings do not remain persistent between logging out and logging in again. Although we are not clearing the settings, the saved list ID is cleared upon logout (added in #54), which requires re-selection after login. Additionally, updating the list sets default values for the settings, overwriting the saved ones.
This PR resolves the issue by preventing the saved Mailchimp list ID from being cleared on logout. The list ID will only be cleared on login if it is not available under the account. Therefore, if we log in with a different user account, the ID will be cleared. otherwise, it will remain unchanged
How to test the Change
Changelog Entry
Credits
Props @jeffpaul @iamdharmesh
Checklist: