Make the form field visibility dependent on the WordPress "Include?" settings instead of the Mailchimp settings.#137
Merged
Conversation
…ttings instead of the Mailchimp settings.
dkotter
approved these changes
Mar 31, 2025
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
Collaborator
QA Update ✅I have verified this PR in the I tested the following on this branch:
Backward.Compatibility-mailchimp.movMailchimp.-.1.movTesting Environment Details
Steps to Test- As mentioned in the PR description.
|
qasumitbagthariya
approved these changes
Apr 2, 2025
Collaborator
Regression / Smoke Test Report ✅Tested with the Testing Environment Details
Next Step- Ready to Merge 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates the existing behavior of how form fields are displayed on the form. Currently, form fields are shown based on a combination of settings from both Mailchimp and WordPress. If a form field is marked as hidden in Mailchimp, it does not appear on the form, while a visible field can be included in the form based on the settings on the WordPress side.
This PR updates this behavior so that form field visibility is determined solely by the "Include?" option in the WordPress settings, regardless of the Mailchimp settings.
When a new list is set up, hidden fields in Mailchimp will have their "Include?" setting turned off (hidden) by default. Additionally, this PR includes an upgrade script to ensure that forms with hidden fields based on Mailchimp settings do not accidentally start displaying after the update.
Closes #34
How to test the Change
Backward Compatibility
trunkbranch:mailchimp.phpby replacing the line with:Changelog Entry
Credits
Props @qasumitbagthariya @dkotter @jeffpaul @MaxwellGarceau @iamdharmesh
Checklist: