[Block Updates] Move Audience Groups to the InnerBlocks to allow reordering.#132
Merged
dkotter merged 6 commits intoenhancement/82from Mar 31, 2025
Merged
[Block Updates] Move Audience Groups to the InnerBlocks to allow reordering.#132dkotter merged 6 commits intoenhancement/82from
dkotter merged 6 commits intoenhancement/82from
Conversation
dkotter
approved these changes
Mar 25, 2025
Collaborator
QA Update ✅I have verified this PR in the I tested the following on this branch:
Screen.Recording.2025-03-26.at.5.57.16.PM.movTesting Environment Details
Steps to Test- As mentioned in the PR description.
|
qasumitbagthariya
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is a follow-up to PR #126, as discussed here.
It removes group visibility settings from the block sidebar and adds groups as an inner block to allow reordering.
Additionally, the PR changes the default value of some attributes from static values to values from the global settings.
How to test the Change
Changelog Entry
N/A
Credits
Props @username, @username2, ...
Checklist: