Conversation
dkotter
approved these changes
Jan 3, 2025
Collaborator
QA Update ✅I have verified this PR in the Screen.Recording.2025-01-16.at.7.20.45.PM.movTesting Environment Details
Steps to Test- As mentioned in the PR description.
|
jeffpaul
approved these changes
Jan 27, 2025
Collaborator
Regression / Smoke Test Report ✅Tested with the Testing Environment Details
|
qasumitbagthariya
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed a bug causing a fatal PHP error when:
us-phone-fatal-error-when-merge-field-not-included.mov
Closes #103
How to test the Change
The video
us-phone-fatal-error-when-merge-field-not-included.movabove can be used as a guide for recreating the testing conditions. However, instead of a fatal error you should see a successful form submission.Phone number
Address
I added a conditional check to ensure address fields were included for submission.
With address
Without address
Changelog Entry
Credits
Props @MaxwellGarceau
Checklist:
I have added tests to cover my change.Small change, not worth writing tests