-
Notifications
You must be signed in to change notification settings - Fork 71
Closed
Labels
Priority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Progress: PR createdProgress: done
Description
Preconditions (*)
- Magento 2.4
Steps to reproduce (*)
- Attempt to plugin to
\Magento\TwoFactorAuth\Observer\ControllerActionPredispatch::executewill not work due to \Magento\TwoFactorAuth\TestFramework\ControllerActionPredispatch being a preference of it - Attempt to plugin to \Magento\TwoFactorAuth\TestFramework\ControllerActionPredispatch will work in dev mode as interceptors are generated on the fly
- Switch to production mode and run
setup:di:compile - No interceptor is generated for
\Magento\TwoFactorAuth\TestFramework\ControllerActionPredispatchbecuase it has<VENDOR_MODULE>/Testin its filepath (excluded in\Magento\Setup\Module\Di\Code\Reader\ClassesScanner::extract)
Expected result (*)
- should be able to plugin to
\Magento\TwoFactorAuth\Observer\ControllerActionPredispatch::execute
Actual result (*)
- Unable to plugin to method due to preference
Suggested solution
- Migrate the
\Magento\TwoFactorAuth\TestFramework\ControllerActionPredispatchpreference to be a plugin keeping the\Magento\TwoFactorAuth\Observer\ControllerActionPredispatchinterceptor in play
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Priority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Progress: PR createdProgress: done