Remove Zend_Json from Customer module#8617
Merged
mmansoor-magento merged 1 commit intomagento:developfrom Feb 21, 2017
Merged
Conversation
…d tests for the new test function
Contributor
|
Keep up the good work @dmanners! :-) |
Contributor
|
@dmanners thank you for removing Zend_Json from Customer module! Greate job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have updated the Customer module's auth pop-up to use the core Magento Json serilizer lib rather than Zend1' json class.
I have also added a new method to be used in the template and a new test to cover this new method.