Skip to content

Remove invalid preferences#3315

Merged
magento-devops-reposync-svc merged 9 commits intomagento:developfrom
fredden:fix-invalid-preferences
Sep 10, 2024
Merged

Remove invalid preferences#3315
magento-devops-reposync-svc merged 9 commits intomagento:developfrom
fredden:fix-invalid-preferences

Conversation

@fredden
Copy link
Member

@fredden fredden commented Jun 8, 2021

Description

These preferences are defined in XML but the classes they reference do not exist. This is blocking progress on magento/magento2#33161

Fixed Issues

None

Manual testing scenarios

No visible changes should be apparent with this change.

Questions or comments

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov changed the base branch from 1.2-develop to develop November 11, 2021 17:47
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@fredden
Copy link
Member Author

fredden commented Jul 14, 2024

@magento run all tests

@fredden
Copy link
Member Author

fredden commented Jul 14, 2024

@engcom-Hotel please can you organise to get this through the Adobe process and merged in, so that we can make progress on magento/magento2#33161. The failed Functional Tests are out of scope for this change. I expect there are entries for each of these in your internal ticketing system already.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit fe5eb90 into magento:develop Sep 10, 2024
@fredden fredden deleted the fix-invalid-preferences branch September 10, 2024 21:23
@engcom-Hotel engcom-Hotel moved this from Reviewer Approved to Done in Inventory - Pull Request Progress Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants