Wrong database isolation between tests or missing cleanups#1721
Merged
Wrong database isolation between tests or missing cleanups#1721
Conversation
Some of the tests were turning off database isolation for no reason and others were not cleaning modified database information
maghamed
reviewed
Oct 3, 2018
| $isSalableResult = $this->isProductSalableForRequestedQty->execute($sku, $stockId, $qty)->isSalable(); | ||
|
|
||
| // Clean up | ||
| $this->saveStockConfiguration->forStockItem($sku, $stockId, $oldStockItemConfiguration); |
Contributor
There was a problem hiding this comment.
as for me in general it's better to move cleaning logic in the tearDown
maghamed
reviewed
Oct 3, 2018
|
|
||
| // Clean up | ||
| $this->saveStockConfiguration->forStock($stockId, $oldStockConfiguration); | ||
| $this->saveStockConfiguration->forStockItem($sku, $stockId, $oldStockItemConfiguration); |
Contributor
Author
There was a problem hiding this comment.
I agree with you, but in this case we had a dataProvider and this was the best way to clean each single modification. In teardown it becomes quite messy and I should retake all the information from the dataproviders.
maghamed
approved these changes
Oct 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tests were turning off database isolation for no reason and others were not cleaning modified database information