MSI-1302: Drop Foreign Key on cataloginventory_stock_item table#1354
Closed
seruymt wants to merge 1 commit into2.3-developfrom
Closed
MSI-1302: Drop Foreign Key on cataloginventory_stock_item table#1354seruymt wants to merge 1 commit into2.3-developfrom
seruymt wants to merge 1 commit into2.3-developfrom
Conversation
maghamed
reviewed
Jun 12, 2018
| * @return void | ||
| * @throws \Exception | ||
| */ | ||
| protected function dropForeignKey(SchemaSetupInterface $setup) |
Contributor
There was a problem hiding this comment.
why do you have this method declared as protected?
maghamed
reviewed
Jun 12, 2018
| --> | ||
| <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd"> | ||
| <module name="Magento_InventoryCatalog" setup_version="1.0.0" /> | ||
| <module name="Magento_InventoryCatalog" setup_version="1.0.0"> |
Contributor
There was a problem hiding this comment.
btw, after declarative schema usage we no need anymore
setup_version="1.0.0 attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1302